Fix NPE with classloader debug logging #1079
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fabric.debug.logClassLoad is set to true, it is possible for an exception to be thrown during the logging which causes the game to crash and the log message to never be printed.
In KnotClassDelegate#getRawClassByteArray, ClassLoader#getResource is used to get a URL instance. ClassLoader#getResource is nullable, meaning it's possible for the url variable to be null.
It is expected that this can be null, thats why there is a check to the isValidParentUrl method.
But if fabric.debug.logClassLoad is enabled, it attempts to log a message and passes the potentially null variable to the getCodeSource method, which throws an exception if url is null: