Make dynamic registry element path include namespace #4180
Conversation
|
An additional thing I will note is that fixing this realigns the behavior with the docs of |
The old method of prepending only applied in certain locations, and thus gives different results depending on the circumstance
|
Change seems fine to me, would it be possible to add some tests to help ensure that this doesnt break again in the future? Could maybe expand one of the existing dynmatic registry tests instead of creating a whole new one. I get that its a breaking change, but I think the best solution is to just go for it in 1.21.3 otherwise we will be waiting a long time to fix. If anyone disagrees please let your thoughts be known. |
|
I can add tests, sure. |
|
I'm not entirely sure how to add tests for this. However, |
PepperCode1
added
the
priority:high
|
I have added a simple test for this, should stop it from happening again. |
… registries (#4180) * Make dynamic registry element path be namespaced Fixes #4179 * Remove old method of prepending the namespace The old method of prepending only applied in certain locations, and thus gives different results depending on the circumstance * Add simple RegistryKeysTest --------- Co-authored-by: modmuss <[email protected]> (cherry picked from commit 3f3c499)
Fixes #4179
Note that since this changes the loading location of modded dynamic registries, this is technically a breaking change to datapacks. However, with 1.21.2 being brand new, and that version already breaking datapack folder structures (with plurals becoming singular), I think now is the perfect time to fix this.