Registry aliasing #4231
Merged
Registry aliasing #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Nov 18, 2024
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Show resolved
Hide resolved
...registry-sync-v0/src/test/java/net/fabricmc/fabric/test/registry/sync/RegistryAliasTest.java
Outdated
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
...registry-sync-v0/src/test/java/net/fabricmc/fabric/test/registry/sync/RegistryAliasTest.java
Outdated
Show resolved
Hide resolved
...registry-sync-v0/src/test/java/net/fabricmc/fabric/test/registry/sync/RegistryAliasTest.java
Outdated
Show resolved
Hide resolved
...registry-sync-v0/src/test/java/net/fabricmc/fabric/test/registry/sync/RegistryAliasTest.java
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
modmuss50
reviewed
Nov 19, 2024
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Show resolved
Hide resolved
modmuss50
reviewed
Dec 5, 2024
...ic-registry-sync-v0/src/main/java/net/fabricmc/fabric/api/event/registry/FabricRegistry.java
Outdated
Show resolved
Hide resolved
modmuss50
approved these changes
Dec 5, 2024
modmuss50
added
last call
modmuss50
reviewed
Dec 5, 2024
...istry-sync-v0/src/testmod/java/net/fabricmc/fabric/test/registry/sync/RegistryAliasTest.java
Show resolved
Hide resolved
...istry-sync-v0/src/main/java/net/fabricmc/fabric/mixin/registry/sync/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
modmuss50
pushed a commit
that referenced
this pull request
Dec 12, 2024
* initial * style * tests + more input checking * revert formatting * requests + more tests * testmod * check not frozen * Fixes * throw on default impl * optimize implementation --------- Co-authored-by: modmuss50 <[email protected]> (cherry picked from commit e2e49f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small API to add aliases to registries, useful for when mods want to change IDs without losing compatibility with existing saves, and without having to resort to datafixer hacks.
The API just consists of a new
FabricRegistryinterface, implemented on all Registry instances via interface injection, with anaddAliasmethod.