Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data generation TAWs #4261

Merged

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Nov 30, 2024

CrossType is needed for many BSMG methods.

@modmuss50 modmuss50 added enhancement New feature or request priority:high High priority PRs that need review and work now. Review these first. labels Nov 30, 2024
@modmuss50 modmuss50 changed the title Add TAW for BlockStateModelGenerator.CrossType Add more data generation TAWs Nov 30, 2024
@modmuss50 modmuss50 merged commit bdca9ac into FabricMC:1.21.4 Nov 30, 2024
4 checks passed
Comment on lines +44 to +45
accessible field net/minecraft/client/data/ItemModelGenerator output Lnet/minecraft/client/data/ItemModelOutput;
accessible field net/minecraft/client/data/ItemModelGenerator modelCollector Ljava/util/function/BiConsumer;
Copy link
Contributor

@SquidDev SquidDev Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two lines are wrong. They should be transitive-accessible!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, yes thats correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants