Ensure that there are no duplicate files across projects. #4301
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
reviewed
Dec 15, 2024
| } | ||
|
|
||
| // Attempt to create a single jar with all files from all nested jars, this will fail if there are duplicate files. | ||
| tasks.register("checkNoDuplicateFiles", Zip) { |
There was a problem hiding this comment.
This could be a Copy too, but I guess this saves some disk space since the files aren't even used
There was a problem hiding this comment.
Yes it could be a Sync, However I think Zip is likely best, if I had to guess zip is likely faster than dealing with 1000s of small files. In the end it doesnt really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents #4300 from happening again, depends on that being merged first.