-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Model Loading API to 1.21.5 #4450
Merged
modmuss50
merged 10 commits into
FabricMC:1.21.5
from
PepperCode1:pr/1.21.5/model-loading-api
Mar 6, 2025
Merged
Update Model Loading API to 1.21.5 #4450
modmuss50
merged 10 commits into
FabricMC:1.21.5
from
PepperCode1:pr/1.21.5/model-loading-api
Mar 6, 2025
+548
−1,063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI: Build failuire should be fixed when you merge. |
modmuss50
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to my untrained eye, just one small question about the api design.
...src/client/java/net/fabricmc/fabric/api/client/model/loading/v1/WrapperUnbakedItemModel.java
Outdated
Show resolved
Hide resolved
….21.5/model-loading-api
- Move the point at which OnLoad is invoked earlier to be inline with how OnLoadBlock is invoked
modmuss50
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
port
Porting existing code to a different version
priority:high
High priority PRs that need review and work now. Review these first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelModifier.*BakeItem
events. Their utility is currently limited as the render state cannot be inspected, but they will be much more useful after the 1.21.5 FRAPI port.ModelModifier.*Bake
events asUnbakedModel
s are not really baked anymoreModelModifier.*BakeBlock
events now accept aBlockState
instead of aModelIdentifier
UnwrappableBakedModel
as it is potentially less useful with the changes to the model system. It will be re-added later if necessary.WrapperBlockStateModel
which simply delegates all method calls to a differentBlockStateModel
. This class existed in vanilla in 1.21.4 asWrapperBakedModel
but was removed.WrapperUnbakedItemModel
which simply delegates all method calls to a differentItemModel.Unbaked
WrapperItemModel
which simply delegates all method calls to a differentItemModel