-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use file extension for CSRG format detection #46
Merged
NebelNidas
merged 13 commits into
FabricMC:dev
from
NebelNidas:detect-format-with-file-extension
Mar 7, 2024
Merged
Use file extension for CSRG format detection #46
NebelNidas
merged 13 commits into
FabricMC:dev
from
NebelNidas:detect-format-with-file-extension
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Oct 6, 2023
This was referenced Oct 6, 2023
NebelNidas
changed the title
Use file extension for format detection
Use file extension for CSRG format detection
Nov 19, 2023
NebelNidas
force-pushed
the
detect-format-with-file-extension
branch
from
March 7, 2024 17:02
bf7a4e6
to
f5f0568
Compare
NebelNidas
force-pushed
the
detect-format-with-file-extension
branch
from
March 7, 2024 19:43
05f5479
to
a10aeeb
Compare
modmuss50
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the passed path is a file and has an extension, use this shortcut instead of parsing file contentsNow we can detect CSRG at least via the path-based API