Only open JAR files if the provided input is a directory #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The behavior definitely need to change, not sure how exactly yet though. It'd theoretically be possible to (optionally) handle nested jars through sub-input-tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some surprising behavior involving scanning JARs.
Previously, when presented with a JAR file, Tiny Remapper would open all of its nested JAR files and treat every file as an input. However, it would not re-construct the file structure. Instead, in the output it would flatten all nested JARs into the top jar, and create conflicts if the user had also added the nested JAR as an input.
This PR reverts that behavior, and makes Tiny Remapper ignore nested JARs.