Implement hashCode and equals methods on Member #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramidzkh
approved these changes
May 26, 2020
|
Shall they be used in hash maps, their fields should be final. Implementing these two is incomplete for hashmap usage without making the fields final. |
|
Ah, hmm, I completely missed that the fields were mutable. Guess I'm just used to most data storage objects like these being immutable. |
Marcono1234
reviewed
May 27, 2020
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return (31 * (31 * owner.hashCode()) + name.hashCode()) + desc.hashCode(); |
There was a problem hiding this comment.
You could use java.util.Objects.hash for that
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { |
There was a problem hiding this comment.
Maybe it should start with if (other == this) { return true; } for better performance for that case, though I don't know if that is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
hashCodeandequalsmethods onMember. This makes usingMemberas a key in a HashMap possible.