Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded TinyRemapper#apply #97

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Devan-Kerman
Copy link
Contributor

image
The singlethreaded-ness of TinyRemapper#apply is a sore point in my code at the moment. There are 2 issues with the current system that the following pull request fixes:

  • The consumer is called on the main thread only
  • Writing the classes is not done in the same step as calling the consumer due to limitations in the API surface

I fix this by

  • Passing the input tags of a class into the consumer method, making it much easier to use apply and write every file at once.
  • Multithreading the apply method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant