Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more renames #3771

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Some more renames #3771

merged 2 commits into from
Jan 21, 2024

Conversation

apple502j
Copy link
Contributor

No description provided.

@apple502j apple502j added bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. javadoc A PR that adds or refactors javadoc. labels Jan 21, 2024
@apple502j apple502j requested a review from modmuss50 January 21, 2024 14:24
@ErrorCraft
Copy link
Contributor

ErrorCraft commented Jan 21, 2024 •
edited
Loading

This has nothing to do with the contents of the PR, but these changes were affected earlier by renaming things for 24w03a and 24w03b and it would probably be useful to include them here. The following fields are instance fields and should be renamed:

  • CookingRecipeSerializer.PACKET_CODEC this one was renamed already
  • SpecialRecipeSerializer.PACKET_CODEC

@apple502j
Copy link
Contributor Author

Cooking is already fixed.

@apple502j apple502j merged commit a4fa08c into FabricMC:24w03b Jan 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings javadoc A PR that adds or refactors javadoc. refactor A PR that renames existing names.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apple502j @ErrorCraft @modmuss50