Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bobby #556

Closed
EquityX opened this issue Dec 27, 2022 · 16 comments
Closed

Bobby #556

EquityX opened this issue Dec 27, 2022 · 16 comments
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added replace Replaces an existing mod

Comments

@EquityX
Copy link

EquityX commented Dec 27, 2022

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/bobby

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/bobby

Source/other link

https://github.com/Johni0702/bobby

Mod file size

770.05 KB

License

(any other license)

What it does

Bobby is a Minecraft mod which allows for render distances greater than the server's view-distance setting.

Why should it be in the modpack

I was having chunks just stop loading until I reload the world. This happened on multiple different modpacks & worlds. It turns out the culprit was Farsight. Even if Farsight wasn't loading any fake chunks it would still cause this problem.

Bobby has had a major update that removed all the stuttering & lag for me that it had before. I've been using it instead of Farsight now & haven't had a single problem. The performance is even improved over Farsight by a lot & Bobby has the benefit of remembering chunks without re exploring them which is a huge plus. Bobby also works in singleplayer & can be configured in the in game menu.

Hold That Chunk Fabulously Optimized 4.5.5 32 Render Distance V sync off
Hold That Chunk

Farsight Fabulously Optimized 4.5.5 32 Render Distance V sync off
Farsight 32

Bobby Fabulously Optimized 4.5.5 32 Render Distance V sync off
Bobby 32

All mods & settings are 100% identical. I only swapped Farsight for Bobby.

Why shouldn't it be in the modpack

Worlds can have mixed chunks on minigame servers. I am currently testing some solutions to see if this can be solved.

Additional details

I suggest setting the singleplayer server view distance to 12 max so players can benefit from extra performance if they exceed 12 view distance in singleplayer.

@EquityX EquityX added the mod New Fabric mod to include label Dec 27, 2022
@Madis0
Copy link
Member

Madis0 commented Dec 27, 2022

Duplicate of #46, post your comments there.

@Madis0 Madis0 marked this as a duplicate of #46 Dec 27, 2022
@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2022
@Madis0 Madis0 added the duplicate This issue or pull request already exists label Dec 27, 2022
@Madis0
Copy link
Member

Madis0 commented Dec 27, 2022

Actually, let's have a fresh one. Have you tested Bobby against Hold That Chunk? Do that and let me know.

@Madis0 Madis0 reopened this Dec 27, 2022
@Madis0 Madis0 added parity Mods that add Optifine, Bedrock or Forge parity and removed duplicate This issue or pull request already exists labels Dec 27, 2022
@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Dec 27, 2022

Actually, let's have a fresh one. Have you tested Bobby against Hold That Chunk? Do that and let me know.

Bobby is even wore than farsight and hold that chunk because it doesn't recognize correctly world change from minigames servers and you end up with mixed world
(by example go in hypixel skyblock in the hub, explore it then come back to your Island and see that far chunks are actually the hub chunks)

@EquityX
Copy link
Author

EquityX commented Dec 27, 2022

Farsight doesn't have the mixed world issue because it doesn't remember chunks at all when world changing. So it is a choice between remembering no chunks when world changing or the wrong chunks when it comes to Bobby. Personally I prefer the mixed chunks as either way you have to re explore the chunks to get them back/correct them & I think the additional benefits from Bobby are worth it. Setting your render distance to the server value will fix the mixed chunks by removing the need for fake chunks, essentially disabling the mod.

I also added results for Hold That Chunk.

@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Dec 27, 2022

Farsight doesn't have the mixed world issue because it doesn't remember chunks at all when world changing. So it is a choice between remembering no chunks when world changing or the wrong chunks when it comes to Bobby. Personally I prefer the mixed chunks as either way you have to re explore the chunks to get them back/correct them & I think the additional benefits from Bobby are worth it. Setting your render distance to the server value will fix the mixed chunks by removing the need for fake chunks, essentially disabling the mod.

I also added results for Hold That Chunk.

Well if you mostly only play in one or 2 worlds it isn't a too big of a problem but if you play on minigames based servers or in lobby based ones it get really weird and would be seen as a very big issue for many people

You should also use the sodium extra FPS features instead of the F3 since it will be far better as the f3 won't lag the game sinc eit won't be present and we will get min, avg and max values

Make sure your instances are updated since you are using an outdated loader version

Are you sure you used exactly the same mods ?

You also should give maximum 4 to 6GB to the game to not kill the JVM Garbage Collector

@osfanbuff63
Copy link
Member

Here's a couple reasons why I would lean on the side of not adding this:

  • Bobby vs Farsight was decided by a public vote, however that hasn't stopped us from testing Hold That Chunk #437.
  • The issue mentioned above - on minigames servers where proxies are used to generate new void worlds every time I can't imagine that solution being helpful
  • A theoretical performance loss by disabling huge caches. Those caches were mentioned as being a reason to not include it in Bobby #46, as taking up tons of storage space isn't ideal.

@Kichura
Copy link
Member

Kichura commented Dec 28, 2022

  • Bobby has been known for causing world loading corruption so it looks like the main spawn is loaded but outside of it causes it to generate fake chunks from other places; in this case, i see this as being not-so-great to implement even if people tell this otherwise.

@Madis0
Copy link
Member

Madis0 commented Dec 28, 2022

If Bobby will be added, the permanent world caching will be disabled by default.

@Madis0 Madis0 added the replace Replaces an existing mod label Dec 28, 2022
@RaptaG
Copy link
Contributor

RaptaG commented Jan 2, 2023

I suggest the next alpha or beta FO release include Bobby for testing in the Modrinth version and then do a comparison with the two mods, just like we did with Bobby vs Farsight.

@osfanbuff63
Copy link
Member

osfanbuff63 commented Jan 2, 2023

That may or may not be a great idea, given that Modrinth versions are now fully supported and Prism relies on Modrinth - which based on the Discord roles isn't an insignificant of our over 1.1k Discord users. Not to mention our number of Modrinth downloads skyrocketing since Prism support was added...

image

image

However it's worth considering for sure.

@lynrayy
Copy link

lynrayy commented Jan 13, 2023

Incompatible with fabulously optimized now :(

@lynrayy
Copy link

lynrayy commented Jan 13, 2023

Im trying to install bobby mod with this modpack and got this:
image

@PoorPocketsMcNewHold
Copy link

@lynrayy commented on Jan 13, 2023, 6:50 PM UTC:

Incompatible with fabulously optimized now :(

Originally posted by @lynrayy in #556 (comment)

It still work fine for me. Remember to disable/remove Hold that Chunk, as it conflict with it, due to achieving "similar" results.

@RaptaG
Copy link
Contributor

RaptaG commented Apr 23, 2023

There now is a patch for the multi-world issue, but the dev needs testers. More information here:
Johni0702/bobby#72 (comment)

@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Apr 23, 2023

There now is a patch for the multi-world issue, but the dev needs testers. More information here:
Johni0702/bobby#72 (comment)

I guess i'll temporarily switch from HTC to Bobby to see how it goes

@Madis0
Copy link
Member

Madis0 commented Sep 14, 2023

Will not be included per #656 (comment) .

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@Madis0 Madis0 added the rejected Mods and changes that will not be added label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added replace Replaces an existing mod
Projects
None yet
Development

No branches or pull requests

8 participants