Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Publish this to PyPi/pip? #21

Open
nsde opened this issue Oct 15, 2022 · 18 comments
Open

Publish this to PyPi/pip? #21

nsde opened this issue Oct 15, 2022 · 18 comments
Labels
enhancement New feature or request question Further information is requested soon™ Will be worked on later

Comments

@nsde
Copy link
Contributor

nsde commented Oct 15, 2022

I took some time the last week to learn how this works and I finally got it to work on a project of mine.

Should I publish this project to PyPi/pip?

This would make the installation extremely simple:

pip install vanilla-installer

And starting the program, too:

vanilla-installer

Please also suggest CLI command abbreviations

The program will be able to be started by simply typing vanilla-installer into the terminal. Should there also be abbrevations? If so, suggest some, please!

@nsde nsde added the question Further information is requested label Oct 15, 2022
@nsde nsde assigned Madis0 and nsde and unassigned Madis0 Oct 15, 2022
@nsde nsde added the enhancement New feature or request label Oct 15, 2022
@osfanbuff63
Copy link
Member

It's worth thinking about. Some of our internal functions can then be depended on by other projects, which could be good or bad. As well, we might want to migrate our buildscript again if we do this, potentially using Poetry just to not have 16 different places to update dependencies, just in the pyproject.toml.

Either way, I think we need to keep using PyInstaller for .exe and etc files, as we ultimately want users to not need Python installed. Obviously, updating with pip is a good option, but we don't want to require Python installed for a simple thing like this.

@Madis0
Copy link
Member

Madis0 commented Oct 16, 2022

Who is the target audience for this? Linux users?

@nsde
Copy link
Contributor Author

nsde commented Oct 16, 2022

Who is the target audience for this? Linux users?

People that already have pip/Python installed. And Linux users, maybe.

@Madis0
Copy link
Member

Madis0 commented Oct 16, 2022

Hmm... I still don't really understand the benefits of PIP for this.
This isn't a CLI-first tool, nor a dependency for anything... unless you want to make it extensible somehow?

@nsde
Copy link
Contributor Author

nsde commented Oct 16, 2022

Hmm... I still don't really understand the benefits of PIP for this. This isn't a CLI-first tool, nor a dependency for anything... unless you want to make it extensible somehow?

Actually, maybe you're right. But I still think that this could be useful for Linux users.

@osfanbuff63
Copy link
Member

Hmm... I still don't really understand the benefits of PIP for this.
This isn't a CLI-first tool, nor a dependency for anything... unless you want to make it extensible somehow?

I will note, Ultrasonic's alt GUI end is calling to the CLI (or so they said it would), and atm the GUI version makes it harder to test changes...so imo having this on pip is a decent idea, but not at least until we're stable.

For Linux users, it would make it easier most likely, and also we don't have to distribute to the system package managers - unless we use an app image - that way, since Python is pre-installed on many systems, or it's easy to get.

Even for other users, it might still be useful if you have Python installed imo, because especially if I add a run gui command to the CLI, then we get both in one package.

As well, some of the internal functions, such as even creating a profile, if we add more parameters to it. Or just running from an alternative script so that FO is installed then you install mods over it? Not sure about that though.

@Madis0
Copy link
Member

Madis0 commented Oct 16, 2022

Okay, then it could be a long-term plan, as long as we make it stable first.

@osfanbuff63
Copy link
Member

osfanbuff63 commented Oct 16, 2022

This is just a note, but https://pypi.org/project/vanilla-installer/ is a 404 meaning we could use that if we decide to.

@osfanbuff63 osfanbuff63 added the on hold Issues or pull requests that are waiting for another issue. label Oct 16, 2022
@RozeFound
Copy link
Contributor

RozeFound commented Oct 16, 2022

An abbreviation fo-install would be nice maybe?

@osfanbuff63
Copy link
Member

Removing assignee for now, until we get to a point where this is more relevant.

@nsde nsde added the soon™ Will be worked on later label Oct 24, 2022
@osfanbuff63
Copy link
Member

I'm thinking about this. If we decide this is worth doing on v1.0 - or not - it's probably worth adding a gui subcommand to the CLI and making the CLI the entrypoint from our pyproject.toml .

@nsde
Copy link
Contributor Author

nsde commented Oct 29, 2022

I'm thinking about this. If we decide this is worth doing on v1.0 - or not - it's probably worth adding a gui subcommand to the CLI and making the CLI the entrypoint from our pyproject.toml .

Personally, I think pip would the easiest and most comfortable way for me to install and update VI.

@osfanbuff63
Copy link
Member

Alright, once we get to a point that we're stable-ish, I'll run a poetry publish on https://test.pypi.org (essentially another instance meant for testing) to, well, test the system :P

I have some more changes locally to make, then we just need to cover the issues here.

@osfanbuff63
Copy link
Member

Update: https://test.pypi.org/project/vanilla-installer exists with some random dev build... so it all works with one command 🎉

@nsde
Copy link
Contributor Author

nsde commented Dec 3, 2022

Great :)

@osfanbuff63 osfanbuff63 removed the on hold Issues or pull requests that are waiting for another issue. label Dec 8, 2022
@osfanbuff63
Copy link
Member

osfanbuff63 commented Dec 8, 2022

What's your username on PyPi @nsde? Looking to add you to the project (or you for me) once it's ready ❤️

@nsde
Copy link
Contributor Author

nsde commented Dec 8, 2022

What's your username on PyPi @nsde?

nsde
image

@nsde
Copy link
Contributor Author

nsde commented Dec 8, 2022

Thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested soon™ Will be worked on later
Projects
None yet
Development

No branches or pull requests

4 participants