This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
[Breaking] PyPi publish changes - unleash the Poetry! #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Actions script is giving alerts about sensitive data being included, You reckon to investigate that? |
Looks like it's upstream, will investigate more tomorrow. |
Confirmed it's an upstream issue with CodeQL not liking requests. It was only finding it in |
osfanbuff63
changed the title
[Breaking, WIP] PyPi publish changes - unleash the Poetry!
[Breaking] PyPi publish changes - unleash the Poetry!
Nov 2, 2022
Kichura
reviewed
Nov 2, 2022
Kichura
reviewed
Nov 2, 2022
Kichura
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good although some questions are yet to be asked.
wouldn't let me add you as a coauthor @Kichura :ioa:
Kichura
approved these changes
Nov 2, 2022
Is this ready to be merged? |
If you think so, I think this could be ready, after all saves some merge conflicts later lol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whew, here's a quick summary of all the breaking changes...
vanilla_installer
instead ofvanilla-installer
(Mentioned on Discord in an internal channel)poetry
envs/
no longer exists, as it's unneededpyproject.toml
, using Poetry's expansions which allows a rule such as>=3.8,<=3.11
.gui
extradocs
group, and development dependencies in thedev
grouppoetry install --with <group>
. Source from Poetry's docspython cli.py
orpython gui.py
poetry install
, it installs the current project as well, as long as you do not specify--no-root
. This allows for the program to be run asvanilla-installer
as long as you have the venv checked out.This is majorly for #21, but using
poetry
instead ofpipenv
if we're going to publish is a convenience thing, as it usespyproject.toml
.