Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

[Breaking] PyPi publish changes - unleash the Poetry! #36

Merged
merged 6 commits into from
Nov 2, 2022
Merged

Conversation

osfanbuff63
Copy link
Member

@osfanbuff63 osfanbuff63 commented Nov 1, 2022

Whew, here's a quick summary of all the breaking changes...

  • Source directory is now vanilla_installer instead of vanilla-installer (Mentioned on Discord in an internal channel)
  • Dependency management has been completely migrated to poetry
    • envs/ no longer exists, as it's unneeded
    • It's much easier to manage more than 1 Python version...
    • ...as it utilizes the pyproject.toml, using Poetry's expansions which allows a rule such as >=3.8,<=3.11.
  • To install the GUI, you must install it with the gui extra
  • Dependencies for docs have been split into the docs group, and development dependencies in the dev group
  • You can no longer run the program using python cli.py or python gui.py
    • This is due to requirements for packaging. When you run poetry install, it installs the current project as well, as long as you do not specify --no-root. This allows for the program to be run as vanilla-installer as long as you have the venv checked out.
  • Probably more but I'm tired and don't have time to write a longer PR description 😅

This is majorly for #21, but using poetry instead of pipenv if we're going to publish is a convenience thing, as it uses pyproject.toml.

@osfanbuff63 osfanbuff63 added this to the Full Release milestone Nov 1, 2022
@osfanbuff63 osfanbuff63 marked this pull request as draft November 1, 2022 00:26
@Kichura
Copy link
Member

Kichura commented Nov 1, 2022

The GitHub Actions script is giving alerts about sensitive data being included, You reckon to investigate that?

@osfanbuff63
Copy link
Member Author

Looks like it's upstream, will investigate more tomorrow.

@osfanbuff63
Copy link
Member Author

Confirmed it's an upstream issue with CodeQL not liking requests. It was only finding it in venv code though, so this may or may not be relevant. Surprising that it only shows up now though.

@osfanbuff63 osfanbuff63 changed the title [Breaking, WIP] PyPi publish changes - unleash the Poetry! [Breaking] PyPi publish changes - unleash the Poetry! Nov 2, 2022
@osfanbuff63 osfanbuff63 marked this pull request as ready for review November 2, 2022 12:21
pyproject.toml Outdated Show resolved Hide resolved
vanilla_installer/gui.py Outdated Show resolved Hide resolved
Copy link
Member

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good although some questions are yet to be asked.

wouldn't let me add you as a coauthor @Kichura :ioa:
@nsde
Copy link
Contributor

nsde commented Nov 2, 2022

Is this ready to be merged?

@osfanbuff63
Copy link
Member Author

If you think so, I think this could be ready, after all saves some merge conflicts later lol

@nsde nsde merged commit 20dccd5 into main Nov 2, 2022
@osfanbuff63 osfanbuff63 deleted the breaking/pypi branch November 2, 2022 21:52
@osfanbuff63 osfanbuff63 mentioned this pull request Nov 18, 2022
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants