reimplement the pipe end detecvtion algorithm to ask the API directly, and use it to pull out pipe ends in the scanner #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahicks92
force-pushed
the
ahicks/faster-pipe-ends
branch
from
ef454d0 to
e188ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a bunch of surface queries, we can ask about the pipe connections on the entity. These always all come back, but the target is nil on any not actually connected, so we just count the nils. By stopping early once we have found 2, we get a small optimization wrt not checking everything in the case of non-end pipes. Then, we can make a scanner backend for pipes which uses it since it is no longer extremely heavyweight.