Explicitly export values on factory namespace #1114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
factory-boy
exports its types, mypy will fail in strict modeif using the
factory
namespace. Specifically,--no-implicit-reexport
flags references to
factory.Factory
(and other similar values) asbeing implicitly exported:
We can instead explicitly export these objects. As a benefit, anybody
who uses the ill-advised
from factory import *
will now at least nolonger have
__author__
and such pollute their namespace.https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport