Add comments

Fairblock · Oct 24, 2024 · 35d19c0 · 35d19c0
1 parent 1af6c20
commit 35d19c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/x/keyshare/keeper/msg_override_pubkey.go b/x/keyshare/keeper/msg_override_pubkey.go
@@ -51,6 +51,7 @@ func (k msgServer) OverrideLatestPubkey(
 		encSharesExistsValidators[encShare.Validator] = true
 	}
 
+	// Remove all validators in the set that not in the current epoch
 	for _, v := range allValidatorSet {
 		if _, exists := encSharesExistsValidators[v.Validator]; !exists {
 			k.RemoveValidatorSet(ctx, v.Validator)

diff --git a/x/keyshare/module/module.go b/x/keyshare/module/module.go
@@ -244,6 +244,9 @@ func (am AppModule) BeginBlock(cctx context.Context) error {
 			for _, v := range qk.EncryptedKeyshares {
 				am.keeper.SetLastSubmittedHeight(ctx, v.Validator, strconv.FormatInt(ctx.BlockHeight(), 10))
 			}
+
+			// We don't need to remove the validators that not in the new round from the set
+			// They won't be slashed because of the new slashing idle validators logic
 		}
 		am.keeper.DeleteQueuedPubkey(ctx)
 		am.pepKeeper.DeleteQueuedPubkey(ctx)