Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas deduction for encrypted tx execution #56

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Add gas deduction for encrypted tx execution #56

merged 12 commits into from
Sep 28, 2023

Conversation

p0p3yee
Copy link
Contributor

@p0p3yee p0p3yee commented Jun 26, 2023

  1. Add gas deduction for encrypted transaction execution

GasUsed is estimated by using SimCheck() function

GasUsed * GasFee will be deducted before executing encrypted transaction, proceed if successfully deducted, revert otherwise.

  1. Add test for gas deduction

  2. Fixed Tx signed from binary can not be decoded in Pep module begin block

Closes #24

@p0p3yee p0p3yee requested a review from bowenyou June 26, 2023 14:22
Copy link
Member

@bowenyou bowenyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note as to the fact that we are only executing the first message in an encrypted transaction

@p0p3yee p0p3yee merged commit 0be4bca into main Sep 28, 2023
1 check passed
@bowenyou bowenyou deleted the fix/issue#24 branch October 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypted Transctions execution is not charged for gas
2 participants