-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vpa: Pod Monitors for prometheus metrics #1222
vpa: Pod Monitors for prometheus metrics #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR!
I recommended a different version change due to the fact that we are adding functionality (according to semver that's a minor version change). Also, could you please add documentation strings to the new values that are being added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs strings. You'll need to run helm-docs --sort-values-order=file
to have them update the readme.
Co-authored-by: Andrew Suderman <[email protected]>
Co-authored-by: Andrew Suderman <[email protected]>
Seems like we need helm/chart-testing#531 to be merged so that we can start disabling that. We're definitely failing at the reuse-values step right now |
LGTM. Thanks! |
Why This PR?
I want to get the VPA metrics in proemtheus
Fixes #
Changes
Changes proposed in this pull request:
Checklist:
[stable/goldilocks]
.Chart.yaml
following Semantic Versioning.helm-docs --sort-values-order=file
has been run for the charts that support it.