Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpa: Pod Monitors for prometheus metrics #1222

Merged
merged 13 commits into from
Jun 14, 2023

Conversation

digiserg
Copy link
Contributor

Why This PR?
I want to get the VPA metrics in proemtheus

Fixes #

Changes
Changes proposed in this pull request:

  • adds optional podMonitor configuration

Checklist:

  • I have included the name of the chart in the title of this PR in square brackets i.e. [stable/goldilocks].
  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

@digiserg digiserg requested a review from sudermanjr as a code owner June 13, 2023 13:36
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR!

I recommended a different version change due to the fact that we are adding functionality (according to semver that's a minor version change). Also, could you please add documentation strings to the new values that are being added?

stable/vpa/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs strings. You'll need to run helm-docs --sort-values-order=file to have them update the readme.

stable/vpa/values.yaml Outdated Show resolved Hide resolved
stable/vpa/values.yaml Outdated Show resolved Hide resolved
@sudermanjr
Copy link
Member

Seems like we need helm/chart-testing#531 to be merged so that we can start disabling that. We're definitely failing at the reuse-values step right now

@sudermanjr
Copy link
Member

LGTM. Thanks!

@sudermanjr sudermanjr merged commit 2edc105 into FairwindsOps:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants