Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui): Added updateTitle() method #145

Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat(gui): Added updateTitle() method #145

merged 2 commits into from
Mar 25, 2024

Conversation

LeeGodSRC
Copy link
Member

No description provided.

@LeeGodSRC
feat(gui): Added updateTitle() method
f31189d 
chore: Bumped version to 0.7.1b2-SNAPSHOT
@LeeGodSRC LeeGodSRC requested a review from AquaticLabs March 25, 2024 12:57
@pull-request-size pull-request-size bot added size/S and removed size/M labels Mar 25, 2024
AquaticLabs
AquaticLabs approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@AquaticLabs AquaticLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I still believe it’d be a good idea to keep an eye on whether or not the titleUpdating boolean really does help. I did do a test with that removed and it also worked, although as you said, it could be pointlessly calling inventory.close()

@LeeGodSRC LeeGodSRC merged commit d482a13 into v0.7 Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AquaticLabs AquaticLabs AquaticLabs approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeGodSRC @AquaticLabs