Add 0.00000000001 to "ambit radius squared" calculations to account f…

…or potential machine precision errors when calculating the ambit at specific angles.
FallingColors · Nov 5, 2024 · 3f6b70e · 3f6b70e
1 parent d5920c9
commit 3f6b70e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/CircleCastEnv.java b/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/CircleCastEnv.java
@@ -139,7 +139,7 @@ public boolean isVecInRangeEnvironment(Vec3 vec) {
             if (sentinel != null
                 && sentinel.extendsRange()
                 && caster.level().dimension() == sentinel.dimension()
-                && vec.distanceToSqr(sentinel.position()) <= SENTINEL_RADIUS * SENTINEL_RADIUS
+                && vec.distanceToSqr(sentinel.position()) <= SENTINEL_RADIUS * SENTINEL_RADIUS + 0.00000000001
             ) {
                 return true;
             }

diff --git a/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/PlayerBasedCastEnv.java b/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/PlayerBasedCastEnv.java
@@ -178,12 +178,13 @@ public boolean isVecInRangeEnvironment(Vec3 vec) {
         if (sentinel != null
             && sentinel.extendsRange()
             && this.caster.level().dimension() == sentinel.dimension()
-            && vec.distanceToSqr(sentinel.position()) <= SENTINEL_RADIUS * SENTINEL_RADIUS
+                // adding 0.00000000001 to avoid machine precision errors at specific angles
+                && vec.distanceToSqr(sentinel.position()) <= SENTINEL_RADIUS * SENTINEL_RADIUS + 0.00000000001
         ) {
             return true;
         }
 
-        return vec.distanceToSqr(this.caster.position()) <= AMBIT_RADIUS * AMBIT_RADIUS;
+        return vec.distanceToSqr(this.caster.position()) <= AMBIT_RADIUS * AMBIT_RADIUS + 0.00000000001;
     }
 
     @Override