Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I saw a localization key that wasn't defined: hexcasting.mishap.invalid_operator_args #616

Closed
Twisted-Code opened this issue Feb 12, 2024 · 3 comments · Fixed by #695
Closed
Assignees

Comments

@Twisted-Code
Copy link

While playing walks' test pack, I encountered a mishap of type "hexcasting.mishap.invalid_operator_args" for which a localization value did not seem to be defined (hence why I got the localization key instead). I'm assuming, if the key were defined, it should probably go somewhere near the invalid_value mishaps, but why didn't it just throw one of those since I think those are usually used when the type is wrong?

The exact case where I saw this key was when I gave Surgeon's Exaltation 3 garbage. I have no idea, yet, if it happens with more-typical-but-still-wrong inputs:
image

@Twisted-Code
Copy link
Author

Twisted-Code commented Mar 22, 2024

Something else I noticed: if you give Surgeon's list, any, num instead of list, num, any, not only does it use this undefined key, it also trashes all three arguments even though the list was in the right spot and the "any" position should allow "any"?

@Twisted-Code
Copy link
Author

Twisted-Code commented Mar 22, 2024

Same thing just happened with Locator's when it got pattern, any by mistake. It garbaged the any, not just the pattern-which-should-have-been-a-list. And, of course, the mishap string was still undefined.
Maybe the first part of that is the intent for this general "invalid args" mishap though, and the real problem is that there should be more specific mishaps triggering instead. Either way I should probably submit a separate issue about it, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
4 participants