Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization for hexcasting.mishap.invalid_operator_args and associated stuff #695

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Add localization for hexcasting.mishap.invalid_operator_args and associated stuff #695

merged 3 commits into from
Jul 13, 2024

Conversation

kineticneticat
Copy link
Contributor

added keys for hexcasting.mishap.invalid_operator_args (plural & singlular)
changed MishapInvalidIotas to MishapInvalidOperatorArgs to match the class name
edited OperationAction to account for above

image

object-Object
object-Object reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@object-Object object-Object left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good; I left a few comments, but none of them are really a big deal. up to you which ones you want to address. tested it locally, seems to work fine

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidOperatorArgs.kt Outdated Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidOperatorArgs.kt Outdated Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidOperatorArgs.kt Outdated Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidOperatorArgs.kt Outdated Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidOperatorArgs.kt Show resolved Hide resolved
Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5 Outdated Show resolved Hide resolved
Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5 Outdated Show resolved Hide resolved
object-Object
object-Object approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for the fix!

@object-Object object-Object linked an issue Jul 13, 2024 that may be closed by this pull request
I saw a localization key that wasn't defined: hexcasting.mishap.invalid_operator_args #616
Closed
@object-Object object-Object changed the title Added hexcasting.mishap.inavid_operator_args and associated stuff Add localization for hexcasting.mishap.invalid_operator_args and associated stuff Jul 13, 2024
@object-Object object-Object enabled auto-merge July 13, 2024 17:03
@object-Object object-Object merged commit e08e58a into FallingColors:main Jul 13, 2024
3 checks passed
@kineticneticat kineticneticat deleted the invalid_operator_args branch July 17, 2024 07:44
@kineticneticat kineticneticat restored the invalid_operator_args branch July 17, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@object-Object object-Object object-Object approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I saw a localization key that wasn't defined: hexcasting.mishap.invalid_operator_args
2 participants
@kineticneticat @object-Object