-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified hexdoc renderer to have a light mode and read draw settings from CSS #653
Conversation
For the auto-update thing, I have a couple of ideas:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those two comments, I think it looks good, though I'm not really that familiar with frontend stuff like this.
I could do either? Though, for both, I would probably add a function to check for changes in the css when reselecting or opening a drawer. I also thought of starting a timer when it detects a manual change in the css (after doing one of the above things) |
I implemented two things for updating from css.
|
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
doc/src/hexdoc_hexcasting/_templates/hexcasting_render.js.jinja
Outdated
Show resolved
Hide resolved
…d some minor code improvements
Changes
Things to Note