Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fabric/Forge dependency files #681

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Update Fabric/Forge dependency files #681

merged 3 commits into from
Jun 14, 2024

Conversation

object-Object
Copy link
Member

  • Adds a mandatory dependency on Forge for Caelus API.
  • Increases the minimum version of Kotlin For Forge to 4.
  • Adds a suggested dependency on Fabric for Mod Menu.

This was linked to issues Jun 13, 2024
Review Forge/Fabric dependencies #578
Closed
Undocumented Mod Menu dependency #397
Closed
SamsTheNerd
SamsTheNerd approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. all the versions look like they match what's in gradle, some seem a little outdated, but i'm not sure that's really an issue, better to support them than to not.

@object-Object object-Object enabled auto-merge June 14, 2024 23:13
@object-Object object-Object merged commit 1aa53ca into main Jun 14, 2024
3 checks passed
@vgskye vgskye mentioned this pull request Aug 15, 2024
Closed
@object-Object object-Object deleted the fix-dependencies branch August 23, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamsTheNerd SamsTheNerd SamsTheNerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Forge/Fabric dependencies Undocumented Mod Menu dependency
2 participants
@object-Object @SamsTheNerd