Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datagen for damage types, fix missing damage type tags #686

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

walksanatora
Copy link
Contributor

closes #622 by adding overcasting dammage to the relevant tags
(also fixes another dammage-related bug i noticed. both overcast and shame having the same id)

@walksanatora
Copy link
Contributor Author

and for once I actually tested this PR against main to make sure it did fix the issue

@object-Object
Copy link
Member

hm. actually, maybe we could datagen these?

@object-Object object-Object changed the title Overcastfix - fixes #622 Add datagen for damage types, fix missing damage type tags Jun 23, 2024
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the datagen stuff looks good to me. I assume the generated files all match the expected behavior for those damage types? I don't know them off the top of my head.

@object-Object
Copy link
Member

This is what was used on 1.19:

super("hexcasting.overcast");
this.bypassArmor();
this.bypassMagic();
this.setMagic();

super("hexcasting.shame");
this.bypassArmor();
this.bypassMagic();
this.setMagic();

@object-Object object-Object merged commit 22239f0 into FallingColors:main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overcasting fails if you wear armor, even unenchanted vanilla leather armor
3 participants