Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flight spells cost zero if the target can already fly #687

Closed
wants to merge 6 commits into from
Closed

Make flight spells cost zero if the target can already fly #687

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c261fc
fix weird dimensions sometimes having different great spells
beholderface Jan 21, 2024
3bcd0c7
Merge branch 'main' of https://github.com/beholderface/HexMod
beholderface Jun 18, 2024
a4f122b
Make the flight spells cost zero if the target can already fly
beholderface Jun 18, 2024
f1b0e89
Merge branch 'main' into main
object-Object Jun 23, 2024
8673a9d
Update Common/src/main/java/at/petrak/hexcasting/common/casting/actio…
beholderface Jun 23, 2024
11045f3
Update OpFlight.kt
beholderface Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions Common/src/main/java/at/petrak/hexcasting/common/casting/actions/spells/OpFlight.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,17 @@ class OpFlight(val type: Type) : SpellAction {
val target = args.getPlayer(0, argc)
val theArg = args.getPositiveDouble(1, argc)
env.assertEntityInRange(target)

val cost = when (this.type) {
Type.LimitRange -> theArg * MediaConstants.DUST_UNIT
// A second of flight should cost 1 shard
Type.LimitTime -> theArg * MediaConstants.SHARD_UNIT
}.roundToLong()

val cost = if (target.abilities.mayfly) {
//zero in order to not just waste media if you can already fly (see https://github.com/FallingColors/HexMod/pull/687 for some discussion)
0L
beholderface marked this conversation as resolved.
Show resolved Hide resolved
} else {
when (this.type) {
Type.LimitRange -> theArg * MediaConstants.DUST_UNIT
// A second of flight should cost 1 shard
Type.LimitTime -> theArg * MediaConstants.SHARD_UNIT
}.roundToLong()
}

// Convert to ticks
return SpellAction.Result(
Expand Down
Loading