-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for playerless block raycasts #719
Conversation
85f6093
to
90ca0e8
Compare
90ca0e8
to
54f7dcc
Compare
huh. HexMod/Fabric/src/main/java/at/petrak/hexcasting/fabric/mixin/FabricClipContextMixin.java Lines 14 to 23 in a763cdf
|
So it turns out this was already fixed, actually. Talia added an equivalent mixin last year in 717dd3e. This issue was introduced in 1a44b31; the actual bug is just the unchecked cast in OpBlockRaycast. It works fine on both Forge and Fabric if that cast is removed. I guess Forge does something like this mixin already? Not sure why it's not needed on Forge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
joyous
fixes #668.
this was made in Codespaces, so this is untested code; it should work but testing may be advisable