Fix #647 - undefined translation strings #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….overcast.player" still needs to be defined in ru_ru and zh_cn.
navarchus
changed the title
navarchus
changed the title
navarchus
changed the title
Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5
Outdated
Show resolved
Hide resolved
|
Datagen shouldn't need to be run for this change btw. The build was failing due to an intermittent ForgeGradle issue (which should be mitigated by #696). |
|
cool cool - thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #647
"death.attack.hexcasting.overcast.player" was missing, added missing string in en_us, still needs to be defined in ru_ru and zh_cn. Verified works (1.20.1, forge-47.1.47).
changed stat.hexcasting.media_overcasted to stat.hexcasting.media_overcast in en_us, ru_ru, and zh_cn. Verified works (1.20.1, forge-47.1.47).
was fixed before this PR. Verified works (1.20.1, forge-47.1.47).