Fix sounds not fading with distance by changing stereo sound files to mono #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited given files from stereo (2 channel) to mono (1) - this change is made due to Minecraft being coded to not have Volume Attenuation for STEREO ogg files and only having it coded for MONO; thus causing stereo to act as if it was being played globally - If it wasn't for the Figrua Helper team I would have never had the thought to dig into this and reveal the problem; Thank you Figura :D
object-Object
changed the title
|
were the other casting sounds already mono? |
|
Yep, I combed thought all of them and these are the only ones that have stereo instead of mono Also feel free to also make adjustments to the sound events now that sound fadeoff is working, might need a few tweaks. Sadly that part is outside my capabilities Thanks for asking |
|
LTGM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited certain sound files that are Stereo-channeled to be instead be mono-channeled due to Minecraft only having Volume Attenuation for .ogg's that are mono-channeled; thus causing stereo ones to play as if they were global (it is in fact how Mojang introduced those sounds too to be global)
-This effectively corrects any issues in regards to hexcasting sounds not fading in volume with distance and will stay that way as long as future/updated sounds remain MONO-CHANNELED (unless of course, you want it to be global = ) )
Replaced audio files have also been trimmed to reduce filesize even if slightly.
Shoutout to the Figura Helper team for helping me with a personal project that leads to me discovering the root cause of this issue
[this PR merge request was made at the request of Walksanator =D]