Add more 7.0 sample files #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
clarkegj,
tychonievich and
lynchrs3
as code owners
tychonievich
reviewed
Jan 8, 2024
| 2 NOTE 1401 | ||
| 2 DATE 1401 | ||
| 1 BIRT | ||
| 2 NOTE 1401/8 |
There was a problem hiding this comment.
The NOTEs provide the corresponding 5.5.1 date linevalues, but seem redundant and a bit strange when in a 7.0 sample file.
Comment on lines
+15
to
+20
| 1 FILE most/paths%3Fget%23escaped%5Blike%5Dthis | ||
| 2 FORM image/bmp | ||
| 1 FILE https://leave.alone?with=args#and-frags | ||
| 2 FORM image/bmp | ||
| 1 FILE https%3a/not.a.url/even-though-similar | ||
| 2 FORM image/bmp |
There was a problem hiding this comment.
These three examples were testing my sample converter's handling of % escapes, which are not addressed in the spec except insofar as they are in the referenced specs RFC 3986 and the WHATWG URL specification. I feel like some kind of clarifying note might make this example clearer, but there's no FILE.NOTE in the spec so that would require some refactoring of this file.
dthaler
force-pushed
the
test-files
branch
2 times, most recently
from
dd5b9ca
to
934b23c
Compare
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7 that exercise parts of GEDCOM 7.0 that aren't in other sample files. Combined atsign.ged into the esiting escapes.ged. Some files not copied include: * char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files are UTF-8 with a BOM. * date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample. * enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample. * obsolete.ged and tiny.ged are the same as the existing minimal70.ged. Addresses part of issue FamilySearch#132 Signed-off-by: Dave Thaler <[email protected]>
Filed FamilySearch/GEDCOM#420 while working on this. Signed-off-by: Dave Thaler <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
RELA doesn't exist in GEDCOM 7 and maximal70.ged already covers the various ROLE test cases in the file. Signed-off-by: Dave Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7 that exercise parts of GEDCOM 7.0 that aren't in other sample files.
Combined atsign.ged into the existing escapes.ged.
Some files not copied include:
Addresses part of issue #132