Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized Layout - First Run #312

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Norwegian-Sardines
Copy link

Standardized sections for each Tag.

Added MILT, DNA, MEDI tag proposals.

Include enumeration suggestions for BIRT, MILT, DNA, MEDI tags

Military Service should be an event.  It has been observed in several GED files as `_MILT`.
First take on changes to the Event Strucutre
First stab at changes to the attributes
Using Automation Tool v1
Automation Update 5/22/2023
Automation Update 5/22/2023
Automation Update, Standardized Layout
Automation Update Standardized
@fisharebest
Copy link
Contributor

"Military Service" has a specific meaning, as well as a general one.

  • a temporary, mandatory conscription of the entire population
  • served in the military

Do we need to distinguish these?

@Norwegian-Sardines
Copy link
Author

Can you help me see this difference better?

I see “military service” as “having been in the military”, regardless for how the person got there, branch, war-time/peace. The only question I my mind would be is this only restricted to the military of a country, or can rebellious militaries (anti government) be included as well.

My suspicion is that maybe the “service” part is what is throwing you! In the USA we have the “Selective Service” which is the act of registering, but not yet participating in the military. That word can be removed and/or a better definition can be generate.

@dthaler dthaler requested a review from tychonievich May 23, 2023 16:17
@Norwegian-Sardines Norwegian-Sardines marked this pull request as draft May 23, 2023 16:42

### Used
- Part of the [GEDCOM X specification](https://github.com/FamilySearch/gedcomx/blob/master/specifications/fact-types-specification.md) as a distinct stucture with URI `http://familysearch.org/v1/CoupleNeverHadChildren
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Part of the [GEDCOM X specification](https://github.com/FamilySearch/gedcomx/blob/master/specifications/fact-types-specification.md) as a distinct stucture with URI `http://familysearch.org/v1/CoupleNeverHadChildren
- Part of the [GEDCOM X specification](https://github.com/FamilySearch/gedcomx/blob/master/specifications/fact-types-specification.md) as a distinct structure with URI `http://familysearch.org/v1/CoupleNeverHadChildren`


## Lived together
### Absence

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "encoded as NCHI 0 point would belong here under Absence



### Used
*In [GEDCOM X](https://github.com/FamilySearch/gedcomx/blob/master/specifications/event-types-specification.md)* with URI http://gedcomx.org/Census
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*In [GEDCOM X](https://github.com/FamilySearch/gedcomx/blob/master/specifications/event-types-specification.md)* with URI http://gedcomx.org/Census
*In [GEDCOM X](https://github.com/FamilySearch/gedcomx/blob/master/specifications/event-types-specification.md)* with URI `http://gedcomx.org/Census`



### Used
*In [GEDCOM X](https://github.com/FamilySearch/gedcomx/blob/master/specifications/event-types-specification.md)* with URI `http://gedcomx.org/Annulment`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the italics?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some had it that way in the original other did not. This should be universally applied or not!

Comment on lines 86 to 88
'''
1 MARR
2 TYPE Common Law
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix markup


### Used
- Part of the GEDCOM v7.0 Specification
- Part of the GEDCOM X specification with URI http://gedcomx.org/Baptism
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Part of the GEDCOM X specification with URI http://gedcomx.org/Baptism
- Part of the GEDCOM X specification with URI `http://gedcomx.org/Baptism`

## Burial
### Description
- Burial can be defined as the disposition of a decedent which can include: Inhumation, Burial at Sea, Cremation, Donation to Research, Lost, Natural, Green, Burial Tree or Scaffolding, cave and probably many other ones depending on culture. -The BURI event can can therefore have BURI.TYPE enumerations of: a) Inhumation, b) Burial at Sea, c) Cremation, d) Donation to Research, e) Lost, f) Natural, g) Green, h) Burial Tree or Scaffolding, i) cave, j) other/phrase
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Burial can be defined as the disposition of a decedent which can include: Inhumation, Burial at Sea, Cremation, Donation to Research, Lost, Natural, Green, Burial Tree or Scaffolding, cave and probably many other ones depending on culture. -The BURI event can can therefore have BURI.TYPE enumerations of: a) Inhumation, b) Burial at Sea, c) Cremation, d) Donation to Research, e) Lost, f) Natural, g) Green, h) Burial Tree or Scaffolding, i) cave, j) other/phrase
- Burial can be defined as the disposition of a decedent which can include: Inhumation, Burial at Sea, Cremation, Donation to Research, Lost, Natural, Green, Burial Tree or Scaffolding, cave and probably many other ones depending on culture.
-The `BURI` event can therefore have `BURI`.`TYPE` enumerations of: a) Inhumation, b) Burial at Sea, c) Cremation, d) Donation to Research, e) Lost, f) Natural, g) Green, h) Burial Tree or Scaffolding, i) cave, j) other/phrase


### Used
- Part of the GEDCOM v7.0 Specification
- Part of the GEDCOM X specification with http://gedcomx.org/Burial
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Part of the GEDCOM X specification with http://gedcomx.org/Burial
- Part of the GEDCOM X specification with `http://gedcomx.org/Burial`


### Value
In [GEDCOM X](https://github.com/FamilySearch/gedcomx/blob/master/specifications/fact-types-specification.md) with URI `http://gedcomx.org/Burial`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be under Used

--------------------------
## Graduation
### Description
A fact of a person's graduation from a scholast institution, may include, public, private, trade, or other schools of study.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A fact of a person's graduation from a scholast institution, may include, public, private, trade, or other schools of study.
A fact of a person's graduation from a scholastic institution, may include, public, private, trade, or other schools of study.

@Norwegian-Sardines
Copy link
Author

Thanks dthaler! Updating as we speak!

@fisharebest
Copy link
Contributor

fisharebest commented May 23, 2023

Can you help me see this difference better?

It's possible I'm creating a distinction that doesn't exist.

But as I understand it, some countries have laws stating that all citizens must complete 1 or 2 years of military training before the age of 25. In the UK, this was called your "National Service".

I've always called this "Military service", and I considered it a separate activity to joining your country's standing army as a full-time employee.


edit/

webtrees has (inherited from phpGedView, inherited from other/unknown applications) two custom tags:

INDI:_MILI = Military
INDI:_MILT = Military service

I have always used them as I described above.

@Norwegian-Sardines
Copy link
Author

Norwegian-Sardines commented May 23, 2023

These changes were in part created via a database and script to make sure that all parts get added. Some of the markdown is automated, others is not! Having not worked with GitHub or its change mechanism before I'm not sure how changes are identified. My expectation was to regenerate the entire .md file with new proposed events/attributes and minor changes like the ones suggested already. Since this is just a draft it can sit that way for an extended time until the list of new and updated tags slows.

This is all your call, I just wanted to start with all Tag entries having the same components. You don't even have to use what I made, but I'm happy to continue this process!

@tychonievich
Copy link
Collaborator

I started a github review, but had some questions first.

What do you mean by "Proposed" in the "Since" column? At first I thought you added it in all the empty cells (which I found unnecessary but at least consistent), but then I noticed it was just some of them (e.g. you left Clan blank and changed SSN to be blank) leaving me very confused.

You and I seem to disagree on what * means. I defined it as

The special value "*" is used to indicate attributes or events that are present in a different way, such as with a set of structures and payloads.

and added it only when there was an exact translation of the concept (such as "Childless" == "NCHI 0"), indicating what that translation was and which version added support for it. I think you put it in every blank cell instead, but I'm not sure why. Is it because EVEN and FACT can cover everything, or some other interpretation?

@Norwegian-Sardines
Copy link
Author

Norwegian-Sardines commented May 25, 2023

Proposed means not found in the GEDCOM v5.5.1 or v7 so it was proposed to be added. I can leave this out if it is too confusing!

I missed a few "Since" like SSN, Nobility Title, Number of Children. I did not review my stuff very well after my data entry. Clan is not a Event/Attribute as far as I know so it should be "proposed".

I've made these changes, and others such as moving some of the "Where used" out of "Value" to "Used", when I started this database and script it was very early into the request for input and had not reconciled your documentation.

GEDCOM X does not differentiat Event and Attribute. Will GEDCOM v7 continue to differentiate these two or follow GEDCOM X? Personally, if events start supporting Typification we will need a value after the each event tag just like attributes, they become very similar!

I misunderstood the true meaning of the "*". I removed it from some of the tags in my database.

I don't have to generate this information from my database. I just find it very difficult to enter changes/suggestions to the document when they had no standard layouts or editor.

I want to participate in helping to better define Event/Attribute tags, implement better tag reuse via "Typification" and adding a way to add additional TYPE via other/phrase but I'm at a loss as to how to do this.

I have a newer draft version.

5/25/2023 v2
@Norwegian-Sardines
Copy link
Author

Can you help me see this difference better?

It's possible I'm creating a distinction that doesn't exist.

But as I understand it, some countries have laws stating that all citizens must complete 1 or 2 years of military training before the age of 25. In the UK, this was called your "National Service".

I've always called this "Military service", and I considered it a separate activity to joining your country's standing army as a full-time employee.

edit/

webtrees has (inherited from phpGedView, inherited from other/unknown applications) two custom tags:

INDI:_MILI = Military INDI:_MILT = Military service

I have always used them as I described above.

Looking at Wikipedia they use “Military Service” to combine both voluntary and conscripted militaries. Saying:

Military service is service by an individual or group in an army or other militia, air forces, and naval forces, whether as a chosen job (volunteer) or as a result of an involuntary draft (conscription).

My thoughts are that _MILI and _MILT are the same just two different programs trying to add a tag without knowing about the other!

I’ve seen the following in documentation.
| _MILT | FTM7 | Military Services |
| MILI | Reunion | Military |
| MILT | Generations | Military Services |

But none have both, so they probably mean the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants