Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SPLAC beside PLAC #520
base: v7.1
Are you sure you want to change the base?
Adding SPLAC beside PLAC #520
Changes from 3 commits
f15658f
d61fbca
3ecbcfb
21712d7
2d498fd
306908b
e8cbb1b
4884147
41b163c
40fd7f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a TYPE/KIND to distinguish ecclesiastical, political, etc. containment. The
_LOC
extension does this withHIERARCHICAL_RELATIONSHIP
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
HIERARCHICAL_RELATIONSHIP
is needed (per existing_LOC
usage) inside a "shared place structure" within aSHARED_PLACE_RECORD
, but not from within aPLACE_REFERENCE
since the latter is not a containment relationship. This suggests that using<<SHARED_PLACE_STRUCTURE>>
in both places may not be appropriate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm less certain that the second version is preferred, since HEAD.PLAC.FORM would apply in the second version, where "at home" would then be labeled a "city" in UI. So we should discuss more.
I'd also ask the question: what is the meaning of HEAD.PLAC.FORM if only SPLAC is used everywhere? If none, then perhaps we need a sentence saying not to use HEAD.PLAC.FORM in that case.