Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't quote NO (or YES just for consistency) #559

Closed
wants to merge 1 commit into from
Closed

Don't quote NO (or YES just for consistency) #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/uri-def.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def expand_prefix(txt, prefixes):

if g7[tag][0] in ('structure', 'enumeration', 'calendar', 'month'):
ptag = re.sub(r'.*-', '', re.sub(r'-[A-Z]?[a-z].*', '', tag))
print('\nstandard tag: '+(repr(ptag) if ptag in ('YES','NO','TRUE','FALSE', '0', '1', '2', '3') else ptag), file=fh)
print('\nstandard tag: '+(repr(ptag) if ptag in ('TRUE','FALSE', '0', '1', '2', '3') else ptag), file=fh)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot remove quotes from strings that are also ways of spelling Boolean values without changing semantics. This suggested change breaks YAML.

If we want to be consistent in where quotes appear, we could instead make an unconditional use of repr


if len(g7[tag][1]) > 0:
print('\nspecification:', file=fh)
Expand Down
11 changes: 9 additions & 2 deletions extracted-files/tags/HEAD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,16 @@ specification:
details.
- `SOUR` describes the originating software.
- `CORP` describes the corporation creating the software.
- `HEAD`.`SOUR`.`DATA` describes a larger database this data is extracted
from.
- `HEAD`.`SOUR`.`DATA` describes a larger database, electronic data source,
or digital repository this data is extracted from.
- `LANG` and `PLAC` give a default value for the rest of the document.

<div class="deprecation">

`HEAD`.`SOUR`.`DATA` is now deprecated and applications should use
`HEAD`.`SOUR`.`NAME` instead.

</div>

label: 'Header'

Expand Down
7 changes: 4 additions & 3 deletions extracted-files/tags/HEAD-SOUR-DATA
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ standard tag: DATA

specification:
- Data
- The electronic data source or digital repository from which this dataset was
exported. The payload is the name of that source, with substructures providing
additional details about the source (not the export).
- The database, electronic data source, or digital repository from which this
dataset was exported. The payload is the name of the database, electronic data
source, or digital repository, with substructures providing additional details
about it (not about the export).

label: 'Data'

Expand Down
2 changes: 1 addition & 1 deletion extracted-files/tags/NO
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: structure

uri: https://gedcom.io/terms/v7/NO

standard tag: 'NO'
standard tag: NO

specification:
- Did not happen
Expand Down
Loading