add GOV ID to exid-types #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register gov.genealogy.net, a historical gazeteer maintained by CompGen, using information provided by Albert Emmerich
tychonievich
requested review from
clarkegj,
dthaler,
albertemmerich,
lynchrs3 and
gibsongk
as code owners
tychonievich
added a commit
to FamilySearch/GEDCOM-registries
that referenced
this pull request
Nov 6, 2024
This file was provided by @albertemmerich along with the JSON entry in FamilySearch/GEDCOM#566
dthaler
reviewed
Nov 6, 2024
exid-types.json
Outdated
| "description": "Historical Gazeteer place ID", | ||
| "contact": "[email protected]", | ||
| "change-controller": "CompGen", | ||
| "reference": "https://gedcom.io/exid-type/GOV-ID" |
There was a problem hiding this comment.
I get 404 not found at this URL
There was a problem hiding this comment.
How about using https://wiki.genealogy.net/GOV
(which is what "About the project" links to from http://gov.genealogy.net/search/name)
There was a problem hiding this comment.
the proposed YAML file links to https://wiki.genealogy.net/GOV. However the YAML file ist not yet uploaded, so the 404 occurs.
|
While uploading this, it occurred to me to wonder why we have both exid-types.json and the uri/exid-type registry; the two appear to be fully redundant with one another. |
tychonievich
commented
Nov 12, 2024
tychonievich
commented
Nov 12, 2024
|
Approved in steering committee 12 OCT 2024 |
tychonievich
added a commit
to FamilySearch/GEDCOM-registries
that referenced
this pull request
Nov 12, 2024
* GOV-ID definition This file was provided by @albertemmerich along with the JSON entry in FamilySearch/GEDCOM#566 * Update uri/exid-types/GOV-ID.yaml * Update uri/exid-types/GOV-ID.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register gov.genealogy.net, a historical gazeteer maintained by CompGen, using information provided by @albertemmerich
See also FamilySearch/GEDCOM-registries#96