Config wasm no errors #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tkmcmaster
commented
Sep 7, 2023
tkmcmaster
commented
- Added empty and json test
- Added additional logging to debug config parser not erroring
- Added optional parameter to force either legacy or scripting parsing
- If the parameter is not passed it will attempt to parse yaml as both v1 and v2. If legacy is true it only parses v1, false only v2.
- Added tests for the new optional config-wasm parameter to force legacy or scripting parsing
- Updated code to not support empty yaml file
- Changed the functionality to mirror the old code that would fail on an emtpy file
- Removed the default empty endpoints array in the yaml parse
- Added a new error if an empty endpoints section is provided
- Updated tests to support changes
- If the parameter is not passed it will attempt to parse yaml as both v1 and v2. If legacy is true it only parses v1, false only v2.
…y or scripting parsing
- Changed the functionality to mirror the old code that would fail on an emtpy file - Removed the default empty endpoints array in the yaml parse - Added a new error if an empty endpoints section is provided - Updated tests to support changes
summersjc
approved these changes
Sep 7, 2023
burnsidepj
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.