-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open source PPaaS Scripting #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add ZipAllMap, and some doc comments and tests * add doctests to pr.sh --------- Co-authored-by: Zachery Olson <[email protected]>
…utput (#140) * Cargo version upgrade * Updated the Guide to include the new available flag options for instructional purposes * Added the ability to include skipBody argument in TryConfig and modified output to honor new skip flag * included the new argument in the TmpTryConfig for testing purposes * change version upgrade back to original as requested * Removed unnessesary matches as requested * Changes made to output format as requested * Format changes as requested * format changes as requested by Rustfmt in the github checks * Manually fixed format errors * Fixed additional fmt failure after updating rust to 1.72 --------- Co-authored-by: Trevor McMaster <[email protected]>
* Updated dependencies and fixed deprecations * Updated Wasm-pack to match the version in the 0.6.0 scripting branch
* Added additional tests for all the example yaml files * Updated the README for the current changes
- Not fully working. Need to get monorepo set up
- Renamed the old flows to show what they are testing - Changed the guide PR to only monitor the guide files - Added new flow for the PPaaS common, agent, and controller
- Added type checking around the S3 errors
- environment variables override all .env files.
* Added initial common directory * Added open source agent code * Added initial controller check-in - Not fully working. Need to get monorepo set up * Removed references to familysearch.org * Added code to the pr script to build the hdr-histogram for the controller * Attempt to fix the common install/build issues in the controller * Added code to make a monorepo out of the common, agent, and controller * Added new PPaaS PR flow - Renamed the old flows to show what they are testing - Changed the guide PR to only monitor the guide files - Added new flow for the PPaaS common, agent, and controller * Updated the PR flow and added husky * Added the .env.test files we're missing for the github action * Changed all catch blocks to catch unknown - Added type checking around the S3 errors * Basic working build * Working version of next buildgit status! * Fixed storybook by removing reference to deprecated zlib * Removed references to fslocal.org examples * Removed husky since it's not needed on all check-ins * Removed duplication in pr script * Re-enabled the react build now that it's working * Fixed the Application Name for the controller for unit tests * Added code to generage a .env.local for the build * Changed the .env.local file to environment variables * Cleaned up the global script to improve performance and nyc output * Fixed the nyc merge * Changed the build environment files back to .env so it can be overridden - environment variables override all .env files.
burnsidepj
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pewpew.com is a url someone owns
We can change it back to familysearch.org since this is in the FamilySearch Repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage Tests:
Common
Agent
Controller
Acceptance: