Adding toaster, dynamically checking pewpewVersion #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pewpew version on Toaster
|
tkmcmaster
requested changes
Mar 13, 2024
tkmcmaster
requested changes
Mar 14, 2024
There was a problem hiding this comment.
I like the toaster and the work you've done, but we can't use a static file. As soon as we have a crashed controller that gets replaced we'll have an outdated latestInFile version. We need to use S3 so new controllers have a version to read. We can initialize it to unknown if there is no file in S3 yet.
I like the progress. Good work!
|
I just had a realization. These changes don't need to be in master since master doesn't have the 0.6.x vs 0.5.x split. These changes really are only needed in the scripting branch. We can put them in master, but they aren't needed in master. @bryan-e-lopez What do you want to do? Do you still want these in master or should we move these code changes to a PR on the |
|
@bryan-e-lopez Run |
tkmcmaster
reviewed
Mar 15, 2024
tkmcmaster
reviewed
Mar 15, 2024
|
New tests: |
|
@tkmcmaster can we merge to master once we review and then we make the changes to merge to
|
tkmcmaster
approved these changes
Mar 18, 2024
tkmcmaster
added a commit
that referenced
this pull request
Mar 19, 2024
* Added eslint key-spacing rule (#204) * Adding toaster, dynamically checking pewpewVersion (#201) * adding files to dynamically show latest pewpew version on Toaster * cleaning up code for lintter to pass * refactoring code to use tags in S3 * removing files from tsconfig * fixing lint rules * fixing spacing as local linter didnt catch those but the build did * missed one space * adding tests, cleaning up files * removing trailing spaces failing on build * adding DS_Store - make specific file to gitignore * updating storybook to show pewpew latest version output --------- Co-authored-by: Bryan <[email protected]>
tkmcmaster
added a commit
that referenced
this pull request
Mar 26, 2024
* Added eslint key-spacing rule (#204) * Adding toaster, dynamically checking pewpewVersion (#201) * adding files to dynamically show latest pewpew version on Toaster * cleaning up code for lintter to pass * refactoring code to use tags in S3 * removing files from tsconfig * fixing lint rules * fixing spacing as local linter didnt catch those but the build did * missed one space * adding tests, cleaning up files * removing trailing spaces failing on build * adding DS_Store - make specific file to gitignore * updating storybook to show pewpew latest version output * Added common constants for the different os executables to common - To differentiate Mac in S3, we'll use pewpew.mac as the file name. - These constants will be used by common, agent, and controller * Updated the agent to remove hardcoded pewpew references - The agent will now use os specific versions of the pewpew executable: pewpew (Linux), pewpew.exe (Windows), and pewpew.mac (Mac) - Updated the README to add instructions for Mac and Windows Users on how to add an OS specific file and where * Updated the controller to remove hardcoded pewpew and pewpew.zip references - The controller will now use os specific versions of the pewpew executable: pewpew (Linux), pewpew.exe (Windows), and pewpew.mac (Mac) - Updated the README to add instructions for Mac and Windows Users on how to add an OS specific file(s) and where * Updated pewpew to the 0.5.13 release * Removed deprecated fs and log calls from util - Removed fs and logger calls from util so it can be used by client functions - Added default exports of common util functions and constants * Fixed issue with import from common bringing in fs into controller * Added fixes for filtering out pre-release versions * Fixed test that was only ignoring one pewpew executable * Added sleep on windows to avoid race condition after unzipping files * Fixed issue with integration tests - POST /pewpew tests need to run before the GET tests to make sure the data is there - After the deletes are completed we need to put back any versions we deleted * Added fix for compiling next.js on Windows - Symlinks do not work on Windows for compiling so we have to copy the file * Added fix for acceptance tests on Windows - Just like the integration tests, we must wait for the unzip to release the lock before we can access the files * Fixed warning during Next.js build on invalid config * Fixed security vulnerabilities * Added fixes missed from merge * Updated README to add Windows and Mac instructions to include scripting pewpew version * Test mac and windows executables (#209) * Added common constants for the different os executables to common - To differentiate Mac in S3, we'll use pewpew.mac as the file name. - These constants will be used by common, agent, and controller * Updated the agent to remove hardcoded pewpew references - The agent will now use os specific versions of the pewpew executable: pewpew (Linux), pewpew.exe (Windows), and pewpew.mac (Mac) - Updated the README to add instructions for Mac and Windows Users on how to add an OS specific file and where * Updated the controller to remove hardcoded pewpew and pewpew.zip references - The controller will now use os specific versions of the pewpew executable: pewpew (Linux), pewpew.exe (Windows), and pewpew.mac (Mac) - Updated the README to add instructions for Mac and Windows Users on how to add an OS specific file(s) and where * Updated pewpew to the 0.5.13 release * Removed deprecated fs and log calls from util - Removed fs and logger calls from util so it can be used by client functions - Added default exports of common util functions and constants * Fixed issue with import from common bringing in fs into controller * Added fixes for filtering out pre-release versions * Fixed test that was only ignoring one pewpew executable * Added sleep on windows to avoid race condition after unzipping files * Fixed issue with integration tests - POST /pewpew tests need to run before the GET tests to make sure the data is there - After the deletes are completed we need to put back any versions we deleted * Added fix for compiling next.js on Windows - Symlinks do not work on Windows for compiling so we have to copy the file * Added fix for acceptance tests on Windows - Just like the integration tests, we must wait for the unzip to release the lock before we can access the files * Fixed warning during Next.js build on invalid config * Fixed security vulnerabilities * Removed additional hard-coded latest and pewpew strings * Fixed the getTags call to get the latest tags (#211) * Fixed the getTags call to get the latest tags - Unit and Integration tests were not catching the bug, fixed the tests, then fixed the code * Cleaned up the logging of currentLatestVersion --------- Co-authored-by: Bryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.