Add lint rules #202
Merged
Add lint rules #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed no-shadow issues to match the version from the controller
summersjc
approved these changes
Mar 14, 2024
I guess I could've split this into the ppaas code vs the guide code. It still would've been the same files just split into two, but it was mostly changing the |
tkmcmaster
added a commit
that referenced
this pull request
Mar 14, 2024
* Bump mio from 0.8.10 to 0.8.11 (#200) Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.10 to 0.8.11. - [Release notes](https://github.com/tokio-rs/mio/releases) - [Changelog](https://github.com/tokio-rs/mio/blob/master/CHANGELOG.md) - [Commits](tokio-rs/mio@v0.8.10...v0.8.11) --- updated-dependencies: - dependency-name: mio dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add lint rules (#202) * Fixed duplicate build:agent in build command * Added additional lint spacing rules * Fixed common, agent, and controller code for the new lint rules * Added spacing and no-shadow lint rules to the guide results viewer * Fixed lint issues in the guide - Fixed no-shadow issues to match the version from the controller --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only "code" changes are in the guide results-viewer so there are no integration testing needed. I manually tested the UI to confirm it is still working. The controller, common, and agent changes are spacing only so no tests other than unittests needed.