-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node dependencies 2024-08-29 #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name field is empty it will populate with 'PASSWORD'
jessica-yauney
approved these changes
Aug 30, 2024
summersjc
approved these changes
Aug 30, 2024
tkmcmaster
added a commit
that referenced
this pull request
Aug 30, 2024
* Fixed dependabot issues (#247) * Fixed npm audit * Fixed results-viewer npm audit * Update node dependencies 2024-08-29 (#249) * Updated lock file to latest * Updated version * Fixed typo in log message * Added code that if the password checkbox is checked and the variable name field is empty it will populate with 'PASSWORD' * Updated eslint to v9 and renamed file * Updated eslint config to flat config * Fixed lint errors and warnings * Fixed type in eslint file * Fixed the sanitizedCopy functions and their tests (lint found we weren't validating) * Guide viewer eslint (#250) * Updated results-viewer dependencies - Updated eslint to v9 - Renamed .eslintrc to eslint.config.mjs - Updated lock file to latest * Updated eslint.config to new flat config * Fixed lint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updated dependencies to latest including eslint. Latest Next.js with Node 22 fails to compile our webassemblies but we can't even use Node 20 yet. Minor fixes for the password boxes and bug fixes found by eslint v9.
Dependencies still not updated:
chai
: Held back due to ESM requirement which Next.js doesn't supportrimraf
: Held back due to requirement of Node 20 (Blueprint/AWS doesn't support Node 20)Changes:
Coverage:
Acceptance: