Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework skins (again) #203

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Rework skins (again) #203

wants to merge 34 commits into from

Conversation

OliverSchlueter
Copy link
Member

@OliverSchlueter OliverSchlueter commented Nov 23, 2024 •
edited
Loading

TODO

  • migrator to migrate the old skincache.yml file
  • error reporting
  • update docs

@OliverSchlueter
Add new skin fetcher
191b307
@OliverSchlueter
Add tests
33c5dda
@OliverSchlueter
Add tests for file skins
72a8431
@OliverSchlueter
Refactor assertions to use expect utility in tests
583815f
@OliverSchlueter
fix typo
447d9d7
@OliverSchlueter
Refactor skin management and remove outdated skin fetching logic
18b86ad
@OliverSchlueter
new skin cache structure
ec4d8e9
@OliverSchlueter
caching
857440d
@OliverSchlueter
saving loading
b737be1
@OliverSchlueter
cache skin onjoin
8694f8d
@OliverSchlueter
rm skin type
e8f85ec
@OliverSchlueter
skin cmd
eb741aa
@OliverSchlueter
use cache
8532b37
@OliverSchlueter
Add skin to memory cache after retrieving from file cache
8547c53
@OliverSchlueter
rm SkinManager#get
fccdf22
@OliverSchlueter
rename default variant to classing
20aaca3
@OliverSchlueter
consider skin variants
be86425
@OliverSchlueter
Refactor skin loading logic in NpcManagerImpl
f617309
@OliverSchlueter
exception handling
3f56bae
@OliverSchlueter
Encode skin identifiers in Base64 for storage consistency
b84dfb9
@OliverSchlueter
Read skin files from plugins/FancyNpcs/skins dir
da34e6f
@OliverSchlueter
Add mineskin api key config option
9fdad09
@OliverSchlueter
Update mineskin java client to 3.0.1
5a27d47
@OliverSchlueter
remove classic variant
933d676
@OliverSchlueter
fix tests
86a95c1
@OliverSchlueter
add back chatcolor tests
0c9d6b1
@OliverSchlueter
add --slim flag to /npc skin command
ebaba21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OliverSchlueter