Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies npm audit #29

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update dependencies npm audit #29

merged 1 commit into from
Oct 23, 2023

Conversation

naveensrinivasan
Copy link
Member

  • Updated npm audit fixes

@naveensrinivasan naveensrinivasan mentioned this pull request Oct 20, 2023
Closed
@rvema
Copy link
Collaborator

rvema commented Oct 20, 2023

lets hold this change until the github action for CI checks are in place. Thanks!

@naveensrinivasan
Copy link
Member Author

lets hold this change until the github action for CI checks are in place. Thanks!

Can you please let me know the reason? This shouldn't affect the CI checks.

@rvema
Copy link
Collaborator

rvema commented Oct 23, 2023

@naveensrinivasan please update the branch so that it can be merged. Thanks for the contribution.

@naveensrinivasan
Update dependencies npm audit
43f105e 
- Updated npm audit fixes

Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan
Copy link
Member Author

@naveensrinivasan please update the branch so that it can be merged. Thanks for the contribution.

👍

rvema
rvema approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@rvema rvema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rvema rvema merged commit 6ee1d90 into FannieMaeOpenSource:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvema rvema rvema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveensrinivasan @rvema