Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silly Slimes #144

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Silly Slimes #144

merged 7 commits into from
Aug 27, 2024

Conversation

fenndragon
Copy link
Contributor

Description

Changed the Sprites of 4 particular slimes


Changelog

🆑

-Changed 4 of the elemental sprites

placeholder
special slime sprites for a special kind of slime
update to slime sprites
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Aug 24, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Silly slimes Silly Slimes Aug 24, 2024
Copy link
Contributor

github-actions bot commented Aug 24, 2024

RSI Diff Bot; head commit 5f26f6c merging into 4923c5e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Mobs/Animals/elemental.rsi

State Old New Status
alive Added
dead Added

Edit: diff updated after 5f26f6c

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should those sprites not be applied to the non-floof slimes also?

{
"version": 1,
"license": "CC0-1.0",
"copyright": "Created by TheShuEd (github) for Space Station 14.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please state the edit you did to the sprites.

Example: Edited by ...

@FoxxoTrystan FoxxoTrystan added the Priority: 3-Low Should be resolved at some point label Aug 24, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the changlog, those seem to relate to all slimes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to reffer to anyone that did a change.

Orignal creator of the sprite + edited by ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blinks no, I specified that I changed 4 slimes sprites, there are only 2 sprites.

there are 4 slimes that get those 2 sprites. it's pretty clear I didn't say I was changing all slimes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also OH! we're doing credits on this stuff now? I... don't actually think I've put credits on any of the work I've done so far...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to mention that you edited the sprites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do I do this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to the PR.
But il accept it.

@Memeji Memeji merged commit f75ce4b into Fansana:master Aug 27, 2024
13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants