Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Consent Menu #162

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Memeji
Copy link
Collaborator

@Memeji Memeji commented Aug 31, 2024

Description

WIP of a per-character consent menu.


TODO

  • Fix Migration issues
  • Add Consent menu text instead of flavor text placeholders.

Changelog

🆑

  • add: Per-character consent menu

@Memeji Memeji added the Status: Do Not Merge Do not merge label Aug 31, 2024
@Memeji Memeji self-assigned this Aug 31, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Aug 31, 2024
@Memeji Memeji marked this pull request as draft August 31, 2024 23:54
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Sep 3, 2024
@Memeji Memeji marked this pull request as ready for review September 3, 2024 21:03
@Memeji Memeji removed the Status: Do Not Merge Do not merge label Sep 3, 2024
@Memeji Memeji changed the title WIP Character Consent Menu Character Consent Menu Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 8, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 12, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Sep 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 17, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 18, 2024
@FoxxoTrystan
Copy link
Collaborator

Il review this PR when im home as you doing database fiddling

@Memeji
Copy link
Collaborator Author

Memeji commented Sep 18, 2024

Your Database, it is fiddled

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 23, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple issues has been found when testing this.

In character menu, Consent is replacing jobs tab.
Consent appear 2 times in the examinable menu, also unable to edit it from there.

I havent not seen or tested this but what about Consent Settings?

And this cannot be merged until the previous consent system is removed to avoid a fuckup conflict.

@Memeji
Copy link
Collaborator Author

Memeji commented Sep 23, 2024

Fair enough, I'm surprised it replaces the job tab. That is odd.
The plan was to use the consent settings currently in the project for toggles while character-specific is for text.

Can you clarify further about "consent settings"?

@FoxxoTrystan
Copy link
Collaborator

conset Settings.

There some already in the previous consent menu but consent settings are Yes/No toggle for this character that we can read, example.

Vore Consent (if off will not allow vore actions, if yes will, ect...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants