Everybody Needs a Kiss #179

neuPanda · 2024-09-07T15:46:38Z

Description.
added kiss interaction and texts
added lick interaction and texts

🆑

add: Kiss an Lick

Mnemotechnician

Same applies to the second action-

Resources/Prototypes/Floof/Interactions/noop_interactions.yml

Mnemotechnician · 2024-09-07T15:57:35Z

Resources/Prototypes/Floof/Interactions/noop_interactions.yml

+  hideByRequirement: true
+  requirement:
+    !type:MobStateRequirement
+    inverted: true


You don't want this to be usable on dead bodies. Probably.

Suggested change

inverted: true

allowedStates: [Alive, Critical]

:( no, there are people who are going to want that

Resources/Locale/en-US/floofstation/interaction/verbs/noop.ftl

Mnemotechnician · 2024-09-08T14:52:37Z

Simple-Station/Einstein-Engines#823 has been merged and is going to be included in #178, so uh please update those later to add some kinda moodlet.

Fansana · 2024-09-10T05:41:45Z

#178 is added please revisit this

added kiss added lick

Co-authored-by: Mnemotechnican <[email protected]>

neuPanda · 2024-09-14T12:54:58Z

i fuckin hate yml

Memeji · 2024-09-14T22:54:41Z

What is the current status for this PR?

ShatteredSwords

The kiss and lick make a hug sound. If this is a limitation or if it is hard to find these, that is totally fair. If you think you can find a properly licensed sound for each of these actions though, that'd be cool!

neuPanda · 2024-09-16T20:39:47Z

The kiss and lick make a hug sound. If this is a limitation or if it is hard to find these, that is totally fair. If you think you can find a properly licensed sound for each of these actions though, that'd be cool!

not sure where the sounds are or how they work, but i am sure there is something out there.
that said you also got me to go back and look at it and realize i missed a 2 lines in the copy paste that needed to be updated

ShatteredSwords · 2024-09-16T20:50:41Z

not sure where the sounds are or how they work, but i am sure there is something out there. that said you also got me to go back and look at it and realize i missed a 2 lines in the copy paste that needed to be updated

Base interactions are located here, which is what looks like ties the sound to whatever. Looks like you'd have to make a new base interaction within the Floof folder and parent it to that. Completely up to you of course! I think we could do it in the future just as easily!

Mnemotechnician · 2024-09-16T22:29:43Z

There's no need to create new bases unless you intend to re-use them

neuPanda · 2024-09-17T12:53:00Z

I need to run everything again after the changes i did yesterday just have not had a chance to open VS yet. it was just an issue i saw in the PR, so i did the quick fix remotely and do still intend to test it

Memeji · 2024-09-19T15:10:03Z

I need to run everything again after the changes i did yesterday just have not had a chance to open VS yet. it was just an issue i saw in the PR, so i did the quick fix remotely and do still intend to test it

Any update on this?

neuPanda · 2024-09-19T15:13:38Z

I need to run everything again after the changes i did yesterday just have not had a chance to open VS yet. it was just an issue i saw in the PR, so i did the quick fix remotely and do still intend to test it

Any update on this?

sorry not yet, been busy with work

neuPanda · 2024-09-19T22:34:43Z

audio's have been updated

ShatteredSwords · 2024-09-20T00:07:43Z

I will test this when I have the chance, very excited!

ShatteredSwords

Sounds don't seem to be working, still uses the default sounds after playtesting. Not sure why! Everything else still is good though.

Mnemotechnician · 2024-09-20T03:43:36Z

Resources/Prototypes/Floof/Interactions/base.yml

@@ -0,0 +1,29 @@
+# Base interaction that involves hands


This entire file can be removed in favor of the suggestion below

will look into this when i have some time, been a bit busty and have not had time to look into this yet. sorry for the delay

Mnemotechnician · 2024-09-20T03:46:22Z

Resources/Prototypes/Floof/Interactions/mood_interactions.yml

+  parent: [BaseGlobal, BaseLips]
+  priority: 0
+  delay: 0.4
+  range: {max: 1}
+  hideByRequirement: true
+  requirement:
+    !type:MobStateRequirement
+    inverted: true


Lesser priority, inlined effect

Suggested change

parent: [BaseGlobal, BaseLips]

priority: 0

delay: 0.4

range: {max: 1}

hideByRequirement: true

requirement:

!type:MobStateRequirement

inverted: true

parent: [BaseGlobal, BaseHands]

priority: -1

delay: 0.4

range: {max: 1}

hideByRequirement: true

requirement:

!type:MobStateRequirement

inverted: true

effectSuccess:

popup: Obvious

sound: {path: /Audio/Floof/Lewd/kiss.ogg}

Mnemotechnician · 2024-09-20T03:47:24Z

Resources/Prototypes/Floof/Interactions/mood_interactions.yml

+  parent: [BaseGlobal, BaseTongue]
+  priority: 0
+  #icon: /Textures/Interface/Actions/hug.png
+  delay: 0.7
+  range: {max: 1}
+  hideByRequirement: true
+  requirement:
+    !type:MobStateRequirement
+    inverted: true


Similarly,

Suggested change

parent: [BaseGlobal, BaseTongue]

priority: 0

#icon: /Textures/Interface/Actions/hug.png

delay: 0.7

range: {max: 1}

hideByRequirement: true

requirement:

!type:MobStateRequirement

inverted: true

parent: [BaseGlobal, BaseTongue]

priority: -2

#icon: /Textures/Interface/Actions/hug.png

delay: 0.7

range: {max: 1}

hideByRequirement: true

effectSuccess:

popup: Obvious

sound: {path: /Audio/Floof/Lewd/lick.ogg}

requirement:

!type:MobStateRequirement

inverted: true

neuPanda requested review from Memeji and FoxxoTrystan as code owners September 7, 2024 15:46

github-actions bot added Status: Needs Review Someone please review this Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Sep 7, 2024

Floof-Station-Bot changed the title ~~Everybody needs a kiss~~ Everybody Needs a Kiss Sep 7, 2024

Mnemotechnician suggested changes Sep 7, 2024

View reviewed changes

Mnemotechnician reviewed Sep 7, 2024

View reviewed changes

Resources/Locale/en-US/floofstation/interaction/verbs/noop.ftl Outdated Show resolved Hide resolved

Mnemotechnician mentioned this pull request Sep 13, 2024

Axel and Luna #180

Merged

neuPanda and others added 3 commits September 13, 2024 21:09

Everybody needs a kiss

c395add

added kiss added lick

Update Resources/Locale/en-US/floofstation/interaction/verbs/noop.ftl

b202a81

Co-authored-by: Mnemotechnican <[email protected]>

Update Resources/Prototypes/Floof/Interactions/noop_interactions.yml

6bbdf76

Co-authored-by: Mnemotechnican <[email protected]>

neuPanda force-pushed the kiss-your-captain branch from 9722c8f to 6bbdf76 Compare September 14, 2024 01:10

neuPanda added 2 commits September 13, 2024 21:33

Updated to add mood modifiers and moved to appropriate files

0358154

fixing a yml white space issue

1a3c422

FoxxoTrystan assigned neuPanda Sep 14, 2024

FoxxoTrystan requested a review from Mnemotechnician September 14, 2024 05:46

FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Sep 14, 2024

maybe this white space.

0123900

ShatteredSwords reviewed Sep 16, 2024

View reviewed changes

Update mood_interactions.yml

fb9928a

Mnemotechnician approved these changes Sep 16, 2024

View reviewed changes

FoxxoTrystan approved these changes Sep 17, 2024

View reviewed changes

adding audio for kiss and lick

2af2cb8

github-actions bot added the Changes: Audio Changes any ogg files label Sep 19, 2024

neuPanda requested review from ShatteredSwords, FoxxoTrystan and Mnemotechnician September 19, 2024 22:34

ShatteredSwords reviewed Sep 20, 2024

View reviewed changes

Mnemotechnician reviewed Sep 20, 2024

View reviewed changes

FoxxoTrystan approved these changes Sep 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Everybody Needs a Kiss #179

Everybody Needs a Kiss #179

neuPanda commented Sep 7, 2024

Mnemotechnician left a comment

Mnemotechnician Sep 7, 2024

neuPanda Sep 7, 2024

Mnemotechnician commented Sep 8, 2024

Fansana commented Sep 10, 2024

neuPanda commented Sep 14, 2024

Memeji commented Sep 14, 2024

ShatteredSwords left a comment

neuPanda commented Sep 16, 2024

ShatteredSwords commented Sep 16, 2024

Mnemotechnician commented Sep 16, 2024

neuPanda commented Sep 17, 2024

Memeji commented Sep 19, 2024

neuPanda commented Sep 19, 2024

neuPanda commented Sep 19, 2024

ShatteredSwords commented Sep 20, 2024

ShatteredSwords left a comment

Mnemotechnician Sep 20, 2024

neuPanda Sep 23, 2024

Mnemotechnician Sep 20, 2024

Mnemotechnician Sep 20, 2024

Everybody Needs a Kiss #179

Are you sure you want to change the base?

Everybody Needs a Kiss #179

Conversation

neuPanda commented Sep 7, 2024

Mnemotechnician left a comment

Choose a reason for hiding this comment

Mnemotechnician Sep 7, 2024

Choose a reason for hiding this comment

neuPanda Sep 7, 2024

Choose a reason for hiding this comment

Mnemotechnician commented Sep 8, 2024

Fansana commented Sep 10, 2024

neuPanda commented Sep 14, 2024

Memeji commented Sep 14, 2024

ShatteredSwords left a comment

Choose a reason for hiding this comment

neuPanda commented Sep 16, 2024

ShatteredSwords commented Sep 16, 2024

Mnemotechnician commented Sep 16, 2024

neuPanda commented Sep 17, 2024

Memeji commented Sep 19, 2024

neuPanda commented Sep 19, 2024

neuPanda commented Sep 19, 2024

ShatteredSwords commented Sep 20, 2024

ShatteredSwords left a comment

Choose a reason for hiding this comment

Mnemotechnician Sep 20, 2024

Choose a reason for hiding this comment

neuPanda Sep 23, 2024

Choose a reason for hiding this comment

Mnemotechnician Sep 20, 2024

Choose a reason for hiding this comment

Mnemotechnician Sep 20, 2024

Choose a reason for hiding this comment