Harpy Instrument Additions #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Mnemotechnician
suggested changes
Sep 11, 2024
| /// When true, only the instrument entity itself can swap its sound. | ||
| /// </summary> | ||
| [DataField] | ||
| public bool OnlySetBySelf = true; |
There was a problem hiding this comment.
This is true by default, meaning that ALL swappable instruments are affected by this change. You didn't modify the yaml prototypes of other instruments, meaning that all swappable instruments (synthesizers, guitars, etc) are affected by this change and cannot be swapped by anyone unless they get possessed by an admin...
You should make it false by default, and set it to true on MapInit in SingerSystem instead.
cynical24
changed the title
|
just some general advice, try writing commit messages that are a bit more on topic, later on that might help to narrow down where an important change happend. |
|
What's the status on this PR? |
FoxxoTrystan
approved these changes
Sep 16, 2024
ShatteredSwords
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds three new harpy instruments: Piano, Church Organ, and Harp.
Changelog
🆑