Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leash Tweaks & Fixes #193

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Conversation

Mnemotechnician
Copy link
Contributor

Description

This:

  • Effectively disables client-side prediction for leash joints (by setting their maximum distance to +inf on the client side), thus fixing the visual glitches happening client-side when you are dragged via a leash.
  • Makes it so that leash joints are re-created if they are broken illegally (mostly by the ss14 physics engine when an entity enters a container or such), which allows leashed entities to be in containers and more, as well as preserves leashes during FTL.
  • Tweaks some parameters of the existing leashes (normal leash length reduced from 3.5m to 3m, maxDistance was adjusted on all leashes to be ~double of their lengths)
  • Adds leash anchors to bots (medibot, janibot, mimebot, two clownbots), for obvious reasons.
  • Removes some redundant code.

Changelog

🆑

  • add: You can now leash janibots, medibots, and more.
  • fix: Leashes no longer cause broken client-side behavior, and no longer break during FTL.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files labels Sep 17, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Leash tweaks & fixes Leash Tweaks & Fixes Sep 17, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Sep 17, 2024
@Memeji Memeji merged commit 5ba8c86 into Fansana:master Sep 17, 2024
11 checks passed
Floof-Station-Bot added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants