Muffled Gas Masks #197
Draft
Muffled Gas Masks #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactors here are a little clunky, sorry. I wanted these three specific gas masks to have a unique Ingredient tag for the sake of crafting.
This is why the GasMaskTags prototype exists: to "reset" the child gas masks to the original tag list. Not pretty but otherwise you would be able to use muffled gas masks in the crafting recipes and waste resources, which would trip up anyone who wanted to make multiple muffled gas masks at a time.
Just the regular one, because the other two gas masks aren't equippable in loadout themselves.
github-actions
bot
added
Status: Needs Review
|
I will review this PR in detail. |
|
I will playtest this when I get home |
ShatteredSwords
suggested changes
Sep 25, 2024
I thought I did this but apparently not. Thanks for reminding me |
I actually don't know if this is necessary because they were moved rather than removed.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Is this PR planned to be worked on? |
Currently I am unable to work due to real life circumstances, but I should be back in action in about two weeks. I might try to find time this week to squeeze in a merge conflict resolution, however. I apologize for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds "muffled" variants to three different gas mask types; the regular gas mask, explorer gas masks, and security gas masks. These muffled gas masks combine the best of both muzzles and gas masks, allowing you to breathe from an internals tank but not allowing you to speak like a normal person.
Why? It's practical. It has sex appeal. It's giving me character ideas. We are one step closer to gear fetish roleplay. It's fucking genius
As another note, this was originally meant to be for a larger PR that involved adding a lot more BDSM/bondage gear (more muzzle and handcuff variants), but this specific feature involved minorly refactoring upstream YAML in a kind of questionable way, so I am PRing this separately for the sake of reviews.
Technical details
The gas masks and muzzle all get a new tag that's like, "[part of the item ID]Ingredient", and that is used in the crafting recipe because recipes are tag-based and not prototype-based. However, I did not want the final result (the muffled gas masks themselves) to have the ingredient tags, so I had to do some nasty-ass YAML refactoring to manipulate the tags in this way.
The fact tags do not allow for inheritance (i.e. inheriting the tag list from parents and being able to tack new entries on) kind of encourages repetitive YAML behavior, unfortunately, but on the other hand it CAN be taken advantage of like I did in this case to remove the ingredient tags in the final result.
As for why I did this weird multiple inheritance take instead of just making a new prototype inheriting from MaskBase: For consistency in case any changes to the regular gas masks are made (besides, uh, their tags)
TODO
Media
Changelog
🆑