Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ethereal.swsl not compiling in Compatibility Mode #261

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

pissdemon
Copy link
Contributor

@pissdemon pissdemon commented Oct 15, 2024

Description

This should fix a regression introduced by #244 that prevents Floofstation from starting when Compatibility Mode is on in the launcher. The launch fail is due to type issues in the shader code. The PR does not change the meaning of the code, just fixes the type issues.

ERROR: 0:263: '*' : wrong operand types - no operation '*' exists that takes a left-hand operand of type 'const int' and a right operand of type 'const float' (or there is no acceptable conversion)
ERROR: 0:263: '+' : wrong operand types - no operation '+' exists that takes a left-hand operand of type 'const float' and a right operand of type 'const int' (or there is no acceptable conversion)
ERROR: 0:266: 'assign' : cannot convert from 'const int' to 'highp float'

Changelog

🆑

  • fix: Fixed regression bug that prevents Floofstation from starting when Compatibility Mode is enabled in the SS14 Launcher

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 15, 2024
@pissdemon pissdemon changed the title Fix ethereal.swsl not compiling on certain GPUs Fix ethereal.swsl not compiling in Compatibility Mode Oct 15, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Oct 15, 2024
@FoxxoTrystan
Copy link
Collaborator

Guh, Seriously?

@FoxxoTrystan
Copy link
Collaborator

Note to self: add this fix to Simple-Station/Einstein-Engines#960

@FoxxoTrystan FoxxoTrystan merged commit 36d3baf into Fansana:master Oct 16, 2024
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants