Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Drinks, Edited Filesystem #39

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

SleepyScarecrow
Copy link
Contributor

@SleepyScarecrow SleepyScarecrow commented Jul 19, 2024

Description

Added in 12 new mixed drinks, 2 new bottles to the booze'o'mat, and edited some filesystem stuff that didn't make sense to me.
The drinks are to give pomjuice and the new aphrodisiacs another purpose, and unfortuantely the bottle'o'cum is just pandering to the masses. The filesystem stuff I changed was simple enough-- there used to be Resources/Prototypes/Floof/ as well as Resources/Prototypes/Floofstation/, I simply merged these both into Resources/Prototypes/Floofstation to make things a bit cleaner.


TODO

  • Pomegranate Foods
  • Pomegranate Cocktails

Additions

(https://cdn.discordapp.com/attachments/1261497448019529790/1263939111392378920/image.png?ex=669c0e87&is=669abd07&hm=e4f0c8f12169961bad739a221c980645bd23540b058b8a78483337f9cbdca635&)
(https://cdn.discordapp.com/attachments/1261497448019529790/1263940347675938919/2024-07-19_15-25-20.mp4?ex=669c0fad&is=669abe2d&hm=3f6cdec1ba6ab7475a46e88f37dc480196764bdfe48f356de230736d575a4baf&)


Changelog

🆑 Tilkku

  • add: Added a new series of cocktails and new bottles to the booze'o'mat

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Jul 19, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title added new drinks, edited filesystem Added New Drinks, Edited Filesystem Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

RSI Diff Bot; head commit 873f93c merging into 74af0ba
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Objects/Consumable/Drinks/anisettebottle.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/Floof/Objects/Consumable/Drinks/blueballer.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/bottleocum.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/Floof/Objects/Consumable/Drinks/demonseed.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/doublecreamblaster.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/emeraldswinger.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/mariejulep.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/orgasmonthebeach.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/pompassion.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/redrocket.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/semenbomb.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/semenhemorrhage.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/watermelonginjizz.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
icon Added
icon_empty Added

Resources/Textures/Floof/Objects/Consumable/Drinks/yeolhandy.rsi

State Old New Status
fill-1 Added
fill-2 Added
fill-3 Added
fill-4 Added
fill-5 Added
icon Added
icon_empty Added

Edit: diff updated after 873f93c

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jul 19, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Jul 19, 2024
@FoxxoTrystan
Copy link
Collaborator

Did not made a review yet as Linter is unhappy, you should fix that.

Also there no need to put changelogs or code related things, changelogs should only be "in-game"/player related changes, not code or directory, if theres changes please state it in the description, witch you did.

@SleepyScarecrow
Copy link
Contributor Author

made linter happy

@FoxxoTrystan
Copy link
Collaborator

Also please do not use discord link for media, just paste it directly in github.

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good, nice change of directory but please make copyright a bit more detailed to find the author if needed, unless the autho wish to not be found.

@FoxxoTrystan FoxxoTrystan added the Status: Awaiting Changes Do not merge due to requested changes label Jul 20, 2024
@FoxxoTrystan FoxxoTrystan self-requested a review July 20, 2024 18:20
@github-actions github-actions bot removed the Status: Awaiting Changes Do not merge due to requested changes label Jul 20, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiscordID: dakodragon

is incorrect and ID is a string of number.

"Made by dakodragon, DiscordID: 1" example.

@FoxxoTrystan FoxxoTrystan merged commit 47a58cd into Fansana:master Jul 22, 2024
12 of 13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants